Skip to content

Enhancement in telemetry preferences flow and some telemetry maintenance changes #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 24, 2025
Merged

Enhancement in telemetry preferences flow and some telemetry maintenance changes #403

merged 5 commits into from
Apr 24, 2025

Conversation

Achal1607
Copy link
Member

@Achal1607 Achal1607 commented Apr 18, 2025 •
edited
Loading

Changes done in this PR:

  • Refactored telemetry preferences since bugs were there in the earlier implementation.
  • Updated copyright headers.
  • Added telemetry tag so that users can find in settings using telemetry tag.
  • Fixed some bugs around telemetry reporter.
  • Telemetry disable and enable uniformed across setting changes.
  • Added some unit tests

@Achal1607 Achal1607 requested a review from sid-srini April 18, 2025 05:14
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 18, 2025
sid-srini
sid-srini previously approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Achal1607. LGTM 👍

@Achal1607 Achal1607 requested a review from sid-srini April 24, 2025 06:06
@Achal1607 Achal1607 merged commit 3c95bae into oracle:telemetry Apr 24, 2025
2 checks passed
@Achal1607 Achal1607 added this to the JVSC 24.1.0 milestone Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sid-srini sid-srini sid-srini approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
JVSC 24.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Achal1607 @sid-srini